Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt(txn commits): Optimize txns by passing Skiplists to Badger #7777

Merged
merged 22 commits into from
May 5, 2021

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented May 5, 2021

In this PR, we use concurrent mutations system, introduced in #7694 , to generate Skiplists directly from a transaction, even before it is committed.

When a transaction does get committed, we replace the key timestamps with the commit timestamp, in-place within the Skiplist. And in case of multiple transactions being committed, merge them together into one bigger Skiplist during the serial commit.

This Skiplist is then handed over to Badger, bypassing its value log and WAL system. Instead, when Badger persists the skiplist into L0 tables, Dgraph gets a callback, which it uses to decide when it is safe to take a Raft snapshot / checkpoint. So, we no longer need Badger's WAL.

Furthermore, live loader is also optimized to better deal with the conflicting transactions, and retrying them as frequently as possible, instead of only towards the end. The updated output from live loader shows we're able to deal with stragglers much better, with them causing almost no delays with this PR.

There's also a bug fix in this PR. The Raft checkpointing code was not getting run as often as it should. This PR fixes that.

Master:
[18:48:34-0700] Elapsed: 08m45s Txns: 21222 N-Quads: 21,221,870 N-Quads/s: 9,033 Aborts: 0
Number of TXs run            : 21240
Number of N-Quads processed  : 21239870
Time spent                   : 8m49.039284385s
N-Quads processed per second : 40150

This PR:
Number of TXs run            : 21240
Number of N-Quads processed  : 21239870
Time spent                   : 6m56.641399434s
N-Quads processed per second : 51057

This change is Reviewable

@github-actions github-actions bot added area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/live-loader Issues related to live loading. area/testing Testing related issues labels May 5, 2021
@manishrjain manishrjain changed the title Mrjn/optimize commits opt(commits): Optimize transaction commits by passing Skiplists to Badger May 5, 2021
@manishrjain manishrjain changed the title opt(commits): Optimize transaction commits by passing Skiplists to Badger opt(txn commits): Optimize txns by passing Skiplists to Badger May 5, 2021
@joshua-goldstein
Copy link
Contributor

For reference the relevant PR in Badger is dgraph-io/badger#1696

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/live-loader Issues related to live loading. area/testing Testing related issues
Development

Successfully merging this pull request may close these issues.

3 participants